Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing example very jittery in Firefox #4271

Closed
jaapster opened this issue Feb 14, 2017 · 9 comments
Closed

Drawing example very jittery in Firefox #4271

jaapster opened this issue Feb 14, 2017 · 9 comments
Labels
environment-specific 🖥️ performance ⚡ Speed, stability, CPU usage, memory usage, or power usage

Comments

@jaapster
Copy link

Drawing and updating a polygon in Firefox using the mapbox-gl-draw example code is very jittery at larger map sizes.

Platform: macOS Sierra on a MacBook Pro mid 2015

Mapbox SDK version: 0.32.1

Steps to trigger behavior

  1. Create an HTML file containing the code of the mapbox-gl-draw example
  2. Open this file in Firefox and set browser size to 1700 x 1000 pixels
  3. Draw a polygon
  4. Update the polygon by dragging one of it's coordinates

Expected behavior

A smooth drawing experience

Actual behavior

The polygon is not changing smoothly. The change is (very) jittery. It feels like the rendered polygon is jumping back and forth between the current state and previous states.

@1ec5
Copy link
Contributor

1ec5 commented Feb 14, 2017

Possibly related? #4060

@ravraponi
Copy link

ravraponi commented Feb 16, 2017

I have found that the Firefox version 51 is very jittery with the drawing tool. The beta or developer version is only slightly better.
Is it because of the webgl2?
https://hacks.mozilla.org/2017/01/webgl-2-lands-in-firefox/

@jaapster
Copy link
Author

I just tested in FF Developer Edition on MacOS and it performs even worse.

@clif-os
Copy link

clif-os commented Apr 2, 2017

Experiencing the same issue with 2 different mapbox web applications. Any change to the drawing or updating of data in-session (ex: for hover effects) is slow and jittery in Firefox and extremely slow internet explorer (but is performant in Chrome).

@eltonjuan
Copy link

eltonjuan commented Apr 2, 2017

Just downloaded Firefox v.48.0b1 and can confirm that this issue was introduced at some point after that.

@1ec5 1ec5 added environment-specific 🖥️ performance ⚡ Speed, stability, CPU usage, memory usage, or power usage labels Apr 2, 2017
@jaapster
Copy link
Author

jaapster commented Nov 17, 2017

I just tested in Firefox 57.0 (Quantum) and drawing is not jittery anymore but very slow. The geometry updates seem to be lagging and have to "catch up" with the cursor. This is surprising as tilting and rotating a full screen map in FF 57 is considerably smoother than in Chrome.

I have included screencaptures using my own drawing module.

Chrome:

chrome

Firefox Quantum:

ff

The more setData requests a source receives, the more it appears to "choke up" in Firefox.

(For IE11 and Egde we can only dream of remotely usable performance)

@mourner
Copy link
Member

mourner commented Jul 25, 2018

I just tested this on Firefox 61 and it seems to work smoothly. 🎉 Let's close this for now then.

@mourner mourner closed this as completed Jul 25, 2018
@mourner
Copy link
Member

mourner commented Jul 25, 2018

For reference, here's the example I tested on: https://www.mapbox.com/mapbox-gl-js/example/mapbox-gl-draw/

@gorshkov-leonid
Copy link
Contributor

gorshkov-leonid commented Sep 20, 2018

Hi, @mourner. Now we are using mapbox-gl-js 0.47.0 and testing on Firefox 62.0. We have lags in this example. You can copy this example and check in Firefox:
https://www.mapbox.com/mapbox-gl-js/example/mapbox-gl-draw/
Note, It is important, open this example in full screen.

I realize that this example uses 'mapbox-gl-draw' plugin and you can say that it is problem of plugin, but we have same problems in own implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environment-specific 🖥️ performance ⚡ Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Development

No branches or pull requests

7 participants