You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following up from #3505 (comment) and #3438 (comment), we should replace certain non-CJK punctuation with their fullwidth equivalents more aggressively to avoid rotating them.
For example, 壹貳參(com) correctly becomes:
壹
貳
參
ᴒ͡
ᴑ
ᴟ
͝
but com(壹貳參) becomes:
ᴒ
ᴑ
ᴟ
壹͡
貳
參
︶
whereas it should be:
ᴒ
ᴑ
ᴟ
︵
壹
貳
參
︶
To get this right, we need to split verticalize_punctuation.lookup into three lookup tables (leftBinding, leftAndRightBinding, and rightBinding) and consider only the side(s) to which the character is naturally bound. So ( would be part of rightBinding because the character to the right is the only one that determines its ideographic-ness, whereas @ would be part of leftAndRightBinding because either adjacent character can make it non-ideographic.
Following up from #3505 (comment) and #3438 (comment), we should replace certain non-CJK punctuation with their fullwidth equivalents more aggressively to avoid rotating them.
For example,
壹貳參(com)
correctly becomes:but
com(壹貳參)
becomes:whereas it should be:
To get this right, we need to split
verticalize_punctuation.lookup
into three lookup tables (leftBinding
,leftAndRightBinding
, andrightBinding
) and consider only the side(s) to which the character is naturally bound. So(
would be part ofrightBinding
because the character to the right is the only one that determines its ideographic-ness, whereas@
would be part ofleftAndRightBinding
because either adjacent character can make it non-ideographic./cc @lucaswoj @nickidlugash
The text was updated successfully, but these errors were encountered: