-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flow types for all public APIs #2851
Comments
The flow definitions can go in this repository's root directory. PR away! |
Are all the properties exposed in https://github.com/mapbox/mapbox-gl-js/blob/master/js/mapbox-gl.js intended to be part of the public API? If so, we should document (I was thinking about this because Studio uses |
|
We now have flow built in! Reframing this ticket to be about adding flow types to all public APIs. |
I create a Flow definition file of this library for Mapbox Studio, and chatted a little with @lucaswoj about putting that definition in this repo.
I can think of some reasons that it would be a good idea to maintain the definitions in this repo:
I can't think of any reason not to put the definitions here. Can anybody else?
And if we do put them here, where should they go? I'm happy to open a PR.
The text was updated successfully, but these errors were encountered: