Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "circle-pitch-alignment" style property #2420

Closed
dpieri opened this issue Apr 11, 2016 · 4 comments
Closed

Add "circle-pitch-alignment" style property #2420

dpieri opened this issue Apr 11, 2016 · 4 comments

Comments

@dpieri
Copy link

dpieri commented Apr 11, 2016

Circle layers do not have an orientation property, neither do polygons. Polygons seem to behave as if orientation was set to map, while circles behave as if it was viewport. This is frustrating for us because it means a map with circle layers looks bad when you tilt it.

Here's an example: https://jsbin.com/doyohewulo/edit?html,output

Is this the best place to raise this issue, or should I do that here: https://github.com/mapbox/mapbox-gl-style-spec? It also happens on the latest Android SDK.

mapbox-gl-js version: 0.16.0

Expected Behavior

Circles go into perspective with the map and circles that do not overlap when pitch=0 also do not overlap when pitch=60

Actual Behavior

Circles in the distance overlap.

@ashleyclough
Copy link

I've noticed the same issue. I can see that the current behaviour is fine if the circles are intended to be used as location markers - like icons, fixed to the viewport. However, if the circles are part of the geometry of the map - I use them to render roundabouts at road junctions from a point data source - then they need to be fixed to the map, rather than the viewport. Would it be possible to have an orientation 'map' or 'viewport' option similar to those already provided for markers and text?

circles fixed to viewport

@lucaswoj lucaswoj changed the title Should circle orientation default to map? Add "circle-orientation" style property Apr 13, 2016
@nickidlugash
Copy link

While a circle orientation property could be a good idea, I still think that the default orientation that makes the most sense for most data viz and basemap use cases is map.

@lucaswoj lucaswoj changed the title Add "circle-orientation" style property Add "circle-pitch-alignment" and "circle-rotation-alignment" style properties Jul 29, 2016
@lucaswoj
Copy link
Contributor

related to mapbox/mapbox-gl-style-spec#459

@jfirebaugh jfirebaugh changed the title Add "circle-pitch-alignment" and "circle-rotation-alignment" style properties Add "circle-pitch-alignment" style property Jun 26, 2017
@jfirebaugh
Copy link
Contributor

Tracking this in #4120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants