featuresAt offset

[anandthakker]

featuresAt is somehow offset from rendered symbol locations:

Using map.featuresAt(e.point, {radius: 10}, ...), where e is the mousemove event.

[ansis]

If you look closely while zooming it looks like the icons aren't centered around their data point. Does the style use icon-translate or icon-offset to move the rendered icon?

[peterqliu]

@anandthakker you can also visualize the bounds of each symbol via map.collisionDebug=true, to see if you're within the area

[anandthakker]

@ansis Nope, neither of those properties is set in the style. I'll check @peterqliu's debug thing out and post if I find anything.

[anandthakker]

@ansis @peterqliu Here's what I see with that collisionDebug setting on:

[anandthakker]

@ansis looked at this with me a few days back, and I think determined the issue is that dot.sdf sprite is not centered in its box. I'd be happy to submit a fix to this, but I know absolutely nothing about how the sprites are built/parsed, so I'd need a nudge in the right direction...

[ansis]

Is there an offset on non-retina screens?

hmm, the sprite looks ok. The sdf dot in the 2x sprite has "pixelRatio": 1. I think SpriteAtlas doesn't properly handle icons with a pixel ratio of 1 in a 2x atlas.

I think #1124 would fix it, but it might be easier to just make a sprite with a 2x dot.

[jfirebaugh]

@anandthakker Was this fixed by one of the extend or featuresAt related changes?

[anandthakker]

@jfirebaugh sorry, haven't been in this project recently. I'll bump it to a more recent version and let you know soon

[anandthakker]

@ansis @jfirebaugh Still happening on 0.11.2, but only on retina screens.

[ansis]

I think this could be fixed by #1919 and/or #2224. Can you still reproduce this with v0.16.0?

[anandthakker]

@ansis In the project where I was reproducing this, I changed the icons to circle, so I don't have an immediate test case.

[ansis]

Alright, thanks. I haven't offsets anywhere else so I'll close this for now.