non-Mapbox sources are billed in v1.x

[hyperknot]

Steps to Trigger Behavior

Load a non-Mapbox source with Mapbox access token specified in v1.x.
The load will be billed by Mapbox.

Detail

The bug is a missing bracket on the 2nd line here:

mapbox-gl-js/src/util/mapbox.js

Lines 392 to 397 in 50adf1c

	if (config.EVENTS_URL &&
	customAccessToken || config.ACCESS_TOKEN &&
	Array.isArray(tileUrls) &&
	tileUrls.some(url => isMapboxURL(url) || isMapboxHTTPURL(url))) {
	this.queueRequest({id: mapId, timestamp: Date.now()}, customAccessToken);
	}

This means everyone who used 1.x with an access token was billed for non-Mapbox source loads.

Simple bug - probably thousands of dollars billed in error to customers.

Note: using Prettier would have made it obvious to see this bug.

[mathewantony31]

Thanks for the report, Zsolt. We've worked with the small number of impacted users to fix the issue by removing the Mapbox access token if they're not using a Mapbox source. We don't have any plans to provide a new gl-js v1 release with this changed as a workaround exists for someone to remove their Mapbox access token.

[hyperknot]

My project was definitely affected and I found no way except for fixing the brackets myself. Removing the token is not an option as I need to be able to switch between Mapbox and non-Mapbox maps.

I was charged for the non-Mapbox usage, I'm trying to communicate it with billing now.

[mathewantony31]

Thanks for raising that, Zsolt. I've prioritized the request with the billing team who've processed a refund on your account.

[hyperknot]

Thanks @mathewantony31 they've issued me a refund now.

[stepankuzmin]

Thanks, everyone! This is now fixed in the v1.13.3 release.