Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markers show in the top-left corner until map is loaded #11020

Closed
adamkovalsky opened this issue Sep 15, 2021 · 4 comments
Closed

Markers show in the top-left corner until map is loaded #11020

adamkovalsky opened this issue Sep 15, 2021 · 4 comments
Labels

Comments

@adamkovalsky
Copy link

mapbox-gl-js version: 2.3.0+

browser: Chrome 93.0.4577.63

Steps to Trigger Behavior

Load/refresh a map with markers attached to it.

Link to Demonstration

https://docs.mapbox.com/help/demos/custom-markers-gl-js/final.html

Expected Behavior

The markers are positioned correctly.

Actual Behavior

The markers are positioned in the top/left corner until the map is loaded. This appears to be a regression in v2.3.0 and onward, and works as expected in v2.2.0. Potentially a regression introduced by #10530.

@rreusser
Copy link
Contributor

Confirmed directly with git-bisect. #10530 indeed introduced this regression.

@rreusser
Copy link
Contributor

Good catch, and spot on determining the cause. ❤️ 👏 🙇 I've submitted #11025 to fix this.

@adamkovalsky
Copy link
Author

Brilliant, thanks for the quick fix!

@rreusser
Copy link
Contributor

No problem! (Though unfortunately we just released the 2.5.0 beta yesterday, so it's currently the longest possible time before the next minor release 2.6.0 which will include this, but still glad to get the fix in. Thanks for reporting this!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants