Update SDK version check for CI #10354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhamley
added
the
skip changelog
karimnaaji
reviewed
Feb 5, 2021
.circleci/config.yml
Outdated
| else | ||
| echo SDK version in mapbox-gl.js does not match $CIRCLE_TAG | ||
| echo SDK version in mapbox-gl.js does not match ${CIRCLE_TAG:1} | ||
| circleci-agent step halt |
There was a problem hiding this comment.
I suggest replacing this halt by a red build, silently failing on that case will lead to forgetting cdn publish if not being thorough on the deployment steps.
karimnaaji
approved these changes
Feb 5, 2021
karimnaaji
pushed a commit
that referenced
this pull request
Feb 8, 2021
karimnaaji
pushed a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
./distfolder and thesdkVersionin the build file does not have thevas the first character, hence the${CIRCLE_TAG:1}change