shift horizon towards center to reduce the number of tiles loaded #10304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
added
the
performance ⚡
karimnaaji
reviewed
Jan 21, 2021
src/geo/transform.js
Outdated
| const farZ = furthestDistance * 1.01; | ||
|
|
||
| // Move the horizon closer to the center. 0 would not shift the horizon. 1 would put the horizon at the center. | ||
| const horizonShift = 0.10; |
There was a problem hiding this comment.
Out of curiosity I tested out other values, I think 10% is a good choice and great compromise. Trying to go higher than that starts showing horizon clipping, and is being visually distracting.
|
@ansis I updated the 3d fixture and ran this branch against v2.0.1:
|
hiding labels whose anchor is above the shifted horizon and caused cascading label changess
karimnaaji
force-pushed
the
shift-horizon
branch
from
a4f1485 to
b65b155
Compare
Wouldn't that be already configurable by specifying top padding value (though that would shift down center of map)? |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shifts the horizon down a bit to reduce the number of tiles in highly pitched views. Everything beyond the new horizon is clipped. The skybox is shifted down to meet the horizon.
The horizon is currently shifted 10% of the distance from the true horizon to the center. Specifying the shift as a fraction keeps the horizon at the same real-world locations as pitch changes. The value is not user-configurable right now but we may want to expose it once fog lands. Fog might also make it possible to shift the horizon even further. By blending the map with the sky the sharp edge might be less jarring.
The number of tiles dropped depends on the view. This view loads 20% less tiles:
The perspective of the map is not affected.
Launch Checklist
mapbox-gl-jschangelog:<changelog>Shift horizon down slightly to reduce the number of tiles loaded for highly-pitched maps.</changelog>