Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clear method public #115

Closed
andrewharvey opened this issue Apr 20, 2017 · 2 comments
Closed

make clear method public #115

andrewharvey opened this issue Apr 20, 2017 · 2 comments
Milestone

Comments

@andrewharvey
Copy link
Collaborator

The _clear method is private, this can be useful for applications extending the geocoder. Is there any reason not to make it public? I'm happy to make the change and add the documentation in a PR but wanted to understand if there was any reasoning behind it.

@scottsfarley93
Copy link

scottsfarley93 commented Mar 26, 2019

Hey @andrewharvey curious if you've had any recent thoughts on this issue. If not, I can take a stab at doing this and get it into the version 4.0.0 release, but wanted to check first to see if you wanted to PR this change.

@andrewharvey
Copy link
Collaborator Author

I still think it's a good idea to make this method public. I haven't done any work on this, so all yours if you wanted to PR it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants