Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct mapbox-gl dependencies #235

Closed
2 tasks
mcwhittemore opened this issue Feb 12, 2016 · 4 comments
Closed
2 tasks

Remove direct mapbox-gl dependencies #235

mcwhittemore opened this issue Feb 12, 2016 · 4 comments

Comments

@mcwhittemore
Copy link
Contributor

Currently mapbox-gl-draw include mapbox-gl as part of its build. This means end users are downloading mapbox-gl twice. Lets find ways to remove these dependencies.

@kelvinabrokwa
Copy link
Contributor

@mcwhittemore for the second one could we just replace mapboxgl.Point with point-geometry?

@lucaswoj
Copy link

We should make upstream changes to avoid the need to inherit mapboxgl.Control. Until then you can read from window.mapboxgl, copy-paste the implementation, or require('mapbox-gl/js/ui/control/control')

@mcwhittemore
Copy link
Contributor Author

@kelvinabrokwa - do we even need a module for this?

@lucaswoj - Are you thinking of breaking Control out of mapbox-gl-js? It feels like this could lead to the just another dependency problem.

@lucaswoj
Copy link

Are you thinking of breaking Control out of mapbox-gl-js? It feels like this could lead to the just another dependency problem.

I'm thinking about removing the need to subclass something to create a control. We can move all the logic from Control to Map. See mapbox/mapbox-gl-js#2118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants