Boolean flag to show local container logs to the terminal (flyteorg#2521

) Signed-off-by: aditya7302 <[email protected]> Signed-off-by: Kevin Su <[email protected]> Co-authored-by: Kevin Su <[email protected]> Signed-off-by: mao3267 <[email protected]>
mao3267 · Aug 2, 2024 · 25381ce · 25381ce
1 parent 758736f
commit 25381ce
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/flytekit/core/container_task.py b/flytekit/core/container_task.py
@@ -59,6 +59,7 @@ def __init__(
         secret_requests: Optional[List[Secret]] = None,
         pod_template: Optional["PodTemplate"] = None,
         pod_template_name: Optional[str] = None,
+        local_logs: bool = False,
         **kwargs,
     ):
         sec_ctx = None
@@ -93,6 +94,7 @@ def __init__(
             requests=requests if requests else Resources(), limits=limits if limits else Resources()
         )
         self.pod_template = pod_template
+        self.local_logs = local_logs
 
     @property
     def resources(self) -> ResourceSpec:
@@ -249,6 +251,11 @@ def execute(self, **kwargs) -> LiteralMap:
         )
         # Wait for the container to finish the task
         # TODO: Add a 'timeout' parameter to control the max wait time for the container to finish the task.
+
+        if self.local_logs:
+            for log in container.logs(stream=True):
+                print(f"[Local Container] {log.strip()}")
+
         container.wait()
 
         output_dict = self._get_output_dict(output_directory)