Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite: Fix webdriver for IE and Firefox #244

Merged
merged 4 commits into from
Sep 6, 2021
Merged

Rewrite: Fix webdriver for IE and Firefox #244

merged 4 commits into from
Sep 6, 2021

Conversation

mantoni
Copy link
Owner

@mantoni mantoni commented Sep 5, 2021

Converted the client.js to es5 to support IE.

Worked around an issue in the mozilla geckodriver: mozilla/geckodriver#1798

@mantoni mantoni requested a review from m90 September 5, 2021 20:46
@mantoni mantoni changed the title Fix webdriver for IE and Firefox Rewrite: Fix webdriver for IE and Firefox Sep 6, 2021
@mantoni mantoni added this to the Mochify Rewrite milestone Sep 6, 2021
Copy link
Collaborator

@m90 m90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying issue took me quite a while to understand. This seems to make sense.

@mantoni mantoni merged commit e55763d into rewrite Sep 6, 2021
@mantoni mantoni deleted the fix-webdriver branch September 6, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants