Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDAaaS Freeze and crash when Browsing to Directory with lots of files #34820

Closed
robertapplin opened this issue Dec 6, 2022 · 4 comments · Fixed by #35482
Closed

IDAaaS Freeze and crash when Browsing to Directory with lots of files #34820

robertapplin opened this issue Dec 6, 2022 · 4 comments · Fixed by #35482
Assignees
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) GUI Issues and pull requests specific to the Mantid Workbench GUI. High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Linux Only Only on Linux

Comments

@robertapplin
Copy link
Contributor

Original reporter: Sarah Rogers, Adhip Rahman

Describe the bug
Browsing to a directory from the Manage User Directories dialog on IDAaaS can sometimes freeze Mantid. Then clicking on the X of the dialog causes Mantid to crash. This seems to happen when browsing to directories that contain a large number of files.

To Reproduce

For example

  1. Create a Mantid workspace on IDAaaS here https://dev.analysis.stfc.ac.uk/
  2. Open ISIS SANS interface
  3. Click Manage User Directories
  4. Click Browse To Directory
  5. Browse to the following directory /archive/NDXLARMOR/Instrument/data/cycle_22_3/. Or another directory containing a large number of files
  6. Mantid should freeze.
  7. Click on the X for the Browse dialog and Mantid will crash

Expected behavior
There should be no freeze if possible, and no crash.

Platform/Version (please complete the following information):

  • IDAaaS
@robertapplin robertapplin added the Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) label Dec 6, 2022
@robertapplin robertapplin added this to the Release 6.6 milestone Dec 6, 2022
@robertapplin robertapplin added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Dec 6, 2022
@gemmaguest gemmaguest removed this from the Release 6.6 milestone Jan 17, 2023
@MialLewis MialLewis added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Feb 23, 2023
@thomashampson thomashampson added the Linux Only Only on Linux label Feb 23, 2023
@thomashampson
Copy link
Contributor

Can we confirm that this is a linux only problem and also that it's not specific to IDAaaS?

@MialLewis
Copy link
Contributor

I'm sure this is a not very good test, but I copied the /archive/NDXLARMOR/Instrument/data/cycle_22_3/ folder onto my hard drive and can access it without hang using WSL. If anyone can check with an actual linux machine that would be great.

@sf1919 sf1919 removed their assignment Feb 24, 2023
@thomashampson
Copy link
Contributor

thomashampson commented Mar 21, 2023

Things to investigate:

  • compare 6.4 conda and non-conda version on IDAaaS
  • try accessing the same archive directories on linux and IDAaaS
  • manid imaging appear to not suffer from the same problem - why not?

@thomashampson
Copy link
Contributor

Thanks to @samtygier-stfc for helping track down a fix for this, see here:
mantidproject/mantidimaging#1742
To summarise:
Mantid imaging's nightly suffers from the same issue since they moved the pyqt5 package installing from pypi to conda-forge. This is because the conda pacakges do no include the GTK integration. See these:
conda-forge/pyqt-feedstock#87
conda-forge/qt-main-feedstock#120
We should be able to fix it by installing the qt-gtk-platformtheme package:
https://github.com/conda-forge/qt-gtk-platformtheme-feedstock

This requires us upgrading qt-core to 5.15.8, which we had pinned back to 5.15.4 due to QTabWidget rendering issues in the instrument viewer and some scientific interfaces (#35013)

@thomashampson thomashampson moved this to In Progress in Release 6.7 ISIS Core Mar 23, 2023
@thomashampson thomashampson added the GUI Issues and pull requests specific to the Mantid Workbench GUI. label Apr 17, 2023
@jhaigh0 jhaigh0 moved this from In Progress to Awaiting Aproval in Release 6.7 ISIS Core Apr 26, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Aproval to Done in Release 6.7 ISIS Core May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) GUI Issues and pull requests specific to the Mantid Workbench GUI. High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Linux Only Only on Linux
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants