Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N/A all contracts on independent multi #2676

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

N/A all contracts on independent multi #2676

wants to merge 2 commits into from

Conversation

SirSaltyy
Copy link
Collaborator

No description provided.

@SirSaltyy SirSaltyy requested a review from jahooma June 14, 2024 05:42
Copy link

vercel bot commented Jun 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 2:07pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 2:07pm
prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 21, 2024 2:07pm

Copy link
Collaborator

@jahooma jahooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Approved, pending a few comments.

web/components/answers/answer-resolve-panel.tsx Outdated Show resolved Hide resolved
web/components/answers/answer-resolve-panel.tsx Outdated Show resolved Hide resolved
const onCancelAll = async () => {
setIsSubmitting(true)
try {
for (const answer of answers) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ask chat gpt to turn this for loop into a Promise.all. This will make it only a bit faster because the server will still resolve each answer sequentially.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't that hit by-IP rate limit?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! I don't know our exact limits, but I think a hundred requests in a short period would be ok.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this (see recent commit), but I think it has introduced an API error.

APIError: High volume of requests. Please try again later.

It managed to get through about 3-4 N/As each time before it then failed to resolve the rest.

web/components/answers/answer-resolve-panel.tsx Outdated Show resolved Hide resolved
web/components/answers/answer-resolve-panel.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants