From 3a43765f79ec8c5c8232849923f33b1104a45577 Mon Sep 17 00:00:00 2001
From: Danny Baumann <dannybaumann@web.de>
Date: Sun, 1 Dec 2024 13:29:33 +0100
Subject: [PATCH] Use colored rounded rect as button for opening color picker

Matches the style of the color temperature picker

Signed-off-by: Danny Baumann <dannybaumann@web.de>
---
 .../org/openhab/habdroid/ui/WidgetAdapter.kt  |  6 ++++--
 .../ic_palette_outline_themed_24dp.xml        | 21 -------------------
 .../layout/widgetlist_coloritem_buttons.xml   | 10 +++++----
 3 files changed, 10 insertions(+), 27 deletions(-)
 delete mode 100644 mobile/src/main/res/drawable/ic_palette_outline_themed_24dp.xml

diff --git a/mobile/src/main/java/org/openhab/habdroid/ui/WidgetAdapter.kt b/mobile/src/main/java/org/openhab/habdroid/ui/WidgetAdapter.kt
index ac8352c0ec..608480ba6a 100644
--- a/mobile/src/main/java/org/openhab/habdroid/ui/WidgetAdapter.kt
+++ b/mobile/src/main/java/org/openhab/habdroid/ui/WidgetAdapter.kt
@@ -1647,7 +1647,7 @@ class WidgetAdapter(
         View.OnLongClickListener {
         private val upButton = itemView.findViewById<View>(R.id.up_button)
         private val downButton = itemView.findViewById<View>(R.id.down_button)
-
+        private val selectColorButton = itemView.findViewById<ImageView>(R.id.select_color_button)
         data class UpDownButtonState(
             val item: Item?,
             val shortCommand: String,
@@ -1660,7 +1660,6 @@ class WidgetAdapter(
                 b.setOnClickListener(this)
                 b.setOnLongClickListener(this)
             }
-            val selectColorButton = itemView.findViewById<View>(R.id.select_color_button)
             selectColorButton.setOnClickListener { handleRowClick() }
         }
 
@@ -1674,6 +1673,9 @@ class WidgetAdapter(
                 downButton.tag = UpDownButtonState(widget.item, "OFF", "DECREASE")
             }
             super.bind(widget)
+
+            val color = widget.state?.asHsv?.toColor() ?: Color.BLACK
+            selectColorButton.setImageDrawable(color.toColoredRoundedRect(selectColorButton.context))
         }
 
         override fun onClick(view: View) {
diff --git a/mobile/src/main/res/drawable/ic_palette_outline_themed_24dp.xml b/mobile/src/main/res/drawable/ic_palette_outline_themed_24dp.xml
deleted file mode 100644
index d1bc2624c2..0000000000
--- a/mobile/src/main/res/drawable/ic_palette_outline_themed_24dp.xml
+++ /dev/null
@@ -1,21 +0,0 @@
-<vector xmlns:android="http://schemas.android.com/apk/res/android"
-    android:width="24dp"
-    android:height="24dp"
-    android:viewportWidth="24"
-    android:viewportHeight="24">
-  <path
-      android:fillColor="#FF000000"
-      android:pathData="M12,22C6.49,22 2,17.51 2,12S6.49,2 12,2s10,4.04 10,9c0,3.31 -2.69,6 -6,6h-1.77c-0.28,0 -0.5,0.22 -0.5,0.5 0,0.12 0.05,0.23 0.13,0.33 0.41,0.47 0.64,1.06 0.64,1.67 0,1.38 -1.12,2.5 -2.5,2.5zM12,4c-4.41,0 -8,3.59 -8,8s3.59,8 8,8c0.28,0 0.5,-0.22 0.5,-0.5 0,-0.16 -0.08,-0.28 -0.14,-0.35 -0.41,-0.46 -0.63,-1.05 -0.63,-1.65 0,-1.38 1.12,-2.5 2.5,-2.5L16,15c2.21,0 4,-1.79 4,-4 0,-3.86 -3.59,-7 -8,-7z"/>
-  <path
-      android:fillColor="#FF000000"
-      android:pathData="M6.5,11.5m-1.5,0a1.5,1.5 0,1 1,3 0a1.5,1.5 0,1 1,-3 0"/>
-  <path
-      android:fillColor="#FF000000"
-      android:pathData="M9.5,7.5m-1.5,0a1.5,1.5 0,1 1,3 0a1.5,1.5 0,1 1,-3 0"/>
-  <path
-      android:fillColor="#FF000000"
-      android:pathData="M14.5,7.5m-1.5,0a1.5,1.5 0,1 1,3 0a1.5,1.5 0,1 1,-3 0"/>
-  <path
-      android:fillColor="#FF000000"
-      android:pathData="M17.5,11.5m-1.5,0a1.5,1.5 0,1 1,3 0a1.5,1.5 0,1 1,-3 0"/>
-</vector>
diff --git a/mobile/src/main/res/layout/widgetlist_coloritem_buttons.xml b/mobile/src/main/res/layout/widgetlist_coloritem_buttons.xml
index 2028638022..1744d3c2cf 100644
--- a/mobile/src/main/res/layout/widgetlist_coloritem_buttons.xml
+++ b/mobile/src/main/res/layout/widgetlist_coloritem_buttons.xml
@@ -9,11 +9,13 @@
         android:contentDescription="@string/content_description_color_up"
         app:icon="@drawable/ic_keyboard_arrow_up_themed_24dp" />
 
-    <Button
-        style="@style/openHAB.ActionButton"
+    <ImageView
         android:id="@+id/select_color_button"
-        android:contentDescription="@string/content_description_open_color_wheel"
-        app:icon="@drawable/ic_palette_outline_themed_24dp" />
+        android:layout_width="48dp"
+        android:layout_height="48dp"
+        android:layout_gravity="center_vertical"
+        android:padding="8dp"
+        android:contentDescription="@string/content_description_open_color_wheel" />
 
     <Button
         style="@style/openHAB.ActionButton"