-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: link to rule names to capa rules website #2338
cli: link to rule names to capa rules website #2338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased)
section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
related: #2100 |
it was really easy to use rich instead of tabulate. i thought there'd be more work but the switch should be painless. |
This comment was marked as resolved.
This comment was marked as resolved.
7c2291e
to
8ed32ef
Compare
CHANGELOG updated or no update needed, thanks! 😄
cdf02ba
to
838dd3d
Compare
I've migrated default rendering to rich. It worked well, and I think we can migrate the other renderers, too. But, I'd propose we all try out this PR for a little bit, and if it works, then update the other renderers. |
838dd3d
to
20981ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, this works in my terminal emulator.
Thanks!
closes mandiant#2319 Update index.html Co-authored-by: Moritz <[email protected]>
4133f68
to
ff27ca1
Compare
@williballenthin I think you have forgotten to omit |
closes #2337
closes #2319
Add modern terminal markup to hyperlink to resources on the web, like entries on the capa rules website.
To make this possible, use rich instead of tabulate to render tables.
Also update the canonical path to rules on the website, to: mandiant.github.io/rules/[rule name]/
Using the rule name from the rule header makes it very easy to generate links to the web pages, rather than using the filename of the rule.
Checklist