Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add path exclusions to python tests.yml workflow #2263

Merged
merged 4 commits into from
Aug 9, 2024
Merged

add path exclusions to python tests.yml workflow #2263

merged 4 commits into from
Aug 9, 2024

Conversation

fariss
Copy link
Collaborator

@fariss fariss commented Aug 9, 2024 •
edited
Loading

closes #2256
Update tests.yml CI workflow to exclude web/, doc/ and Markdown files

This PR modifies the tests.yml workflow to:

  • Ignore changes in the web/ and doc/ directory
  • Ignore changes to Markdown files (.md) throughout the repository
  • Run tests and checks for all other file changes

Let's first try and merge this PR and use #2258 as a test example.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@fariss fariss added dont merge Indicate a PR that is still being worked on CI Continuous Integration configuration labels Aug 9, 2024
williballenthin
williballenthin reviewed Aug 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
williballenthin
williballenthin approved these changes Aug 9, 2024
View reviewed changes
Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge inline suggestions and then ready to go

@fariss fariss removed the dont merge Indicate a PR that is still being worked on label Aug 9, 2024
@williballenthin williballenthin merged commit f69fabc into mandiant:master Aug 9, 2024
23 checks passed
@williballenthin
Copy link
Collaborator

thanks @s-ff !

@mr-tz mr-tz mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin approved these changes

@mr-tz mr-tz Awaiting requested review from mr-tz

@mike-hunhoff mike-hunhoff Awaiting requested review from mike-hunhoff

Assignees
No one assigned
Labels
CI Continuous Integration configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webui: disable Python tests for updates to webui (and vice versa)
2 participants
@fariss @williballenthin