-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix black and mypy #2146
fix black and mypy #2146
Conversation
only need to fix deptry:
@s-ff how do you recommend to handle these, add these to exclusions or elsewhere? |
I believe we should not exlcude these, but instead introduce them as part of |
rather than |
not sure, I love the new scripts and updated install mechanism... |
This would require a documentation update as well, to inform users who want to use scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased)
section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
I agree, I don't want to add more steps for users. But the above profile can help with deptry checks. The new script has an import guard, such that when a required dependency is not found, it explains to the user what to do. Given that we have so many scripts with different setups, maybe this is a reasonable pattern? Then the |
I'm definitely open to alternatives and further discussions. |
CHANGELOG updated or no update needed, thanks! 😄
Co-authored-by: Willi Ballenthin <[email protected]>
closes #2145
WIP
Checklist