Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include rule caching in PyInstaller build process #2097

Merged
merged 8 commits into from
Jun 4, 2024
Merged

include rule caching in PyInstaller build process #2097

merged 8 commits into from
Jun 4, 2024

Conversation

fariss
Copy link
Collaborator

@fariss fariss commented May 28, 2024

Closes #1361.

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

The following commit introduces a new function that caches the capa
rule set, so that users don't have to manually run ./scripts/cache-
ruleset.py, before running pyintaller.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed

@github-actions github-actions bot dismissed their stale review May 28, 2024 22:12

CHANGELOG updated or no update needed, thanks! 😄

.github/workflows/build.yml Show resolved Hide resolved
.github/pyinstaller/pyinstaller.spec Show resolved Hide resolved
.github/pyinstaller/pyinstaller.spec Outdated Show resolved Hide resolved
@fariss fariss requested review from williballenthin and mr-tz May 28, 2024 22:24
.github/pyinstaller/pyinstaller.spec Outdated Show resolved Hide resolved
.github/pyinstaller/pyinstaller.spec Outdated Show resolved Hide resolved
.github/pyinstaller/pyinstaller.spec Show resolved Hide resolved
@fariss fariss marked this pull request as ready for review June 1, 2024 19:11
.github/pyinstaller/pyinstaller.spec Show resolved Hide resolved
capa/rules/cache.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good now, thanks!

@mr-tz mr-tz merged commit 508a09e into mandiant:master Jun 4, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensure standalone binary can work without embedded cache
3 participants