ghidra: add Ghidra feature extractor and supporting code #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghidra backend
New Feature: Ghidra Backend - Initial Merge
* ghidra-backend ci working, fix CHANGELOG * temp: Add backend-ghidra to CI test workflow & add versioning to matrix * lint to avoid failure * linting for CI * cleanup CI, integrate actions, simplify installations * fix gradle repo * fix typo * fix submodule checkout for rules & test data * fix relative test data path * remove unnecessary steps * add flag to mkdir to resolve pipeline failure
* Revert "colton: removed redundant imports & object, locally tested" This reverts commit 3da233d. * removed redundant imports & objects, local test confirmation * linted with isort * linted with black * linted with pycodestyle * additional linting * rebasing to avoid merge conflicts
Implement Ghidra backend file feature extraction
* save progress * implement loop detection * implement recursive call detection * lint repo * fix python/java import errors * simplify recursion detection * streamline loop detection, fix helper function signature
* save progress * implement loop detection * implement recursive call detection * lint repo * fix python/java import errors * simplify recursion detection * implement tight loop extraction * streamline loop detection, fix helper function signature * begin stackstring extraction * implement is_mov_imm_to_stack() * implement stackstring extraction, fixture test passing * clean & lint, pass fixture tests * temp: resolve linting issues * temp: fix linting issues * implement reviewed changes, simplify functions * fix tight loop extraction
mike-hunhoff
added
enhancement
* hotfix: fix ghidrathon download
colton-gabertan
approved these changes
Aug 28, 2023
|
@williballenthin and @mr-tz thoughts on squashing the merge when ready? |
|
The history looks fairly clean so we could also do a merge, but squash also works for me. |
mr-tz
approved these changes
Aug 29, 2023
Co-authored-by: Moritz <[email protected]>
Co-authored-by: Moritz <[email protected]>
Co-authored-by: Moritz <[email protected]>
|
I can do a detailed review on Thursday. But, given the other LGTMs, no need to delay on my account. I will add comments here regardless that we can address after-the-fact. |
|
woohoo! |
|
Awesome job on this! Thanks @colton-gabertan and @mike-hunhoff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a result of @colton-gabertan 's Google Summer of Code (GSoC) 2023 project that integrates capa with Ghidra using the Python 3 support provided by Ghidrathon. Colton has provided a summary of his work on this project here.
Closes #49.