Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binja: get_instruction should attach the list of associated LLIL instructions to the instruction object #2520

Open
xusheng6 opened this issue Dec 3, 2024 · 2 comments

Comments

@xusheng6
Copy link
Contributor

xusheng6 commented Dec 3, 2024

At

def get_instructions(self, fh: FunctionHandle, bbh: BBHandle) -> Iterator[InsnHandle]:

Currently, several instruction level analysis tries to get the associated LLIL instruction given an address using the API get_llil_at or get_llils_at. These should be avoided and the lookup should better be just done once

@williballenthin
Copy link
Collaborator

see 73f56f5 for an implementation

@xusheng6 xusheng6 changed the title binja: get_instruction shoudl attach the list of associated LLIL instructions to the instruction object binja: get_instruction should attach the list of associated LLIL instructions to the instruction object Dec 3, 2024
@xusheng6
Copy link
Contributor Author

xusheng6 commented Dec 3, 2024

see 73f56f5 for an implementation

Oh nice! I was once a bit confused by what you are trying to do with that PR, but now I realized that apparently you did almost exactly what I wanted to do. Thanks! And I will look into it ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants