Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize Binary Ninja backend #2397

Closed
williballenthin opened this issue Sep 24, 2024 · 1 comment
Closed

optimize Binary Ninja backend #2397

williballenthin opened this issue Sep 24, 2024 · 1 comment
Labels
binary-ninja bug Something isn't working performance Related to capa's performance

Comments

@williballenthin
Copy link
Collaborator

The Binary Ninja backend is really slow. Like many times slower than vivisect or IDA. From a quick profile, check_segment_for_pe takes up a majority of the runtime. Let's optimize this.
@williballenthin williballenthin added bug Something isn't working binary-ninja performance Related to capa's performance labels Sep 24, 2024
@williballenthin
Copy link
Collaborator Author

I think its the calls to find_all_data

williballenthin added a commit that referenced this issue Sep 24, 2024
@williballenthin
binary ninja: optimize embedded PE scanning
4281e3a 
closes #2397
williballenthin added a commit that referenced this issue Sep 24, 2024
@williballenthin
binary ninja: optimize embedded PE scanning
3327603 
closes #2397
williballenthin added a commit that referenced this issue Sep 24, 2024
@williballenthin
binary ninja: optimize embedded PE scanning
77beab7 
closes #2397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
binary-ninja bug Something isn't working performance Related to capa's performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@williballenthin