-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add links from CLI output to capa rules website #2337
Comments
other places:
|
Does this feature work with all terminal emulators? I imagine only modern consoles supporting this |
Yeah, when unsupported, then the text falls back to how it's shown today. And I don't think there's logic that does this - the terminal emulator just ignores the control codes it doesn't understand. |
It doesn't work under tmux but does under zellij and xterm. i can test Windows Thermal Terminal later today. |
we can use a modern terminal feature to make some text a link to a URL, such as described here: https://www.willmcgugan.com/blog/tech/post/real-working-hyperlinks-in-the-terminal-with-rich/
So, for example, each rule name in the default output could be a link to the rules website, showing the rule content.
I think that for terminals that don't support this feature, the link degrades to text, just like is shown today.
The
rich
library that we use for rendering already has a link feature that we can use here.The text was updated successfully, but these errors were encountered: