limit code size EIP170 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
ayrat555
modified the milestones:
Pass Blockchain common tests for Frontier,
Simple node (MVP)
germsvel
approved these changes
Aug 14, 2018
| {:error, {params.state, 0, SubState.empty()}} | ||
|
|
||
| # EIP170 https://github.com/ethereum/EIPs/blob/master/EIPS/eip-170.md | ||
| byte_size(output) > 24_577 -> |
There was a problem hiding this comment.
What do you think about extracting this condition to a function that is more self-explanatory?
# in the `cond` block
eip_170_byte_size?(output) ->
# then further below
def eip_170_byte_size?(output), do: byte_size(output) > 24_577
# or even better, add docs
@doc """
This is implemented because of EIP170
See more at https://github.com/ethereum/EIPs/blob/master/EIPS/eip-170.md
"""
def eip_170_byte_size?(output), do: byte_size(output) > 24_577What do you think?
There was a problem hiding this comment.
yes, good idea. btw it looks like this change affects previous tests so I'll rewrite it using EVM.Configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-170.md