Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of sharp in favor of less problematic library #187

Closed
enzy opened this issue Dec 29, 2017 · 2 comments
Closed

Get rid of sharp in favor of less problematic library #187

enzy opened this issue Dec 29, 2017 · 2 comments
Labels
🐶 help wanted 🛠️ enhancement

Comments

@enzy
Copy link
Contributor

enzy commented Dec 29, 2017

Currently the biggest blocker and trouble maker is the sharp image processing module. It causes problems during installation and prevents from packing mango-cli into a single executable.

Examine potential of https://github.com/oliver-moran/jimp for our needs.
@FilipChalupa FilipChalupa mentioned this issue Dec 29, 2017
Open
@enzy enzy mentioned this issue Jan 3, 2018
Closed
2 tasks
@enzy
Copy link
Contributor Author

enzy commented Jan 23, 2018 •
edited
Loading

From the investigation in the PR #191, there is enormous performance cost in case of JIMP:

image

So I'm rulling JIMP out for now.

@enzy
Copy link
Contributor Author

enzy commented Oct 3, 2018

There is no alternative and sharp made a good progress in its prebuild binaries

@enzy enzy closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐶 help wanted 🛠️ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace sharp with jimp module manGoweb/mango-cli
1 participant
@enzy