Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade checkout and upload-artifacts actions #12880

Merged
merged 1 commit into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/bgfxshaders.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ jobs:
- uses: msys2/setup-msys2@v2
with:
install: git make mingw-w64-x86_64-gcc mingw-w64-x86_64-python mingw-w64-x86_64-libc++
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
- name: Prevent make from rebuilding GLSL parser source
run: |
touch 3rdparty/bgfx/3rdparty/glsl-optimizer/src/glsl/glcpp/glcpp-lex.c
Expand All @@ -35,7 +37,8 @@ jobs:
env:
MINGW64: "/mingw64"
run: make shaders
- uses: actions/upload-artifact@master
- uses: actions/upload-artifact@main
with:
name: mame-bgfx-${{ github.sha }}
path: bgfx/shaders
if-no-files-found: error
8 changes: 5 additions & 3 deletions .github/workflows/ci-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ permissions:
contents: read

jobs:

build-linux:
runs-on: ubuntu-latest
strategy:
Expand All @@ -43,7 +42,9 @@ jobs:
subtarget: mame
executable: mame
steps:
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update
Expand All @@ -65,10 +66,11 @@ jobs:
run: ./${{ matrix.executable }} -listxml | python scripts/build/makedep.py reconcilelist -l src/mame/${{ matrix.subtarget }}.lst -
- name: ORM check
run: python scripts/minimaws/minimaws.py load --executable ./${{ matrix.executable }} --softwarepath hash
- uses: actions/upload-artifact@master
- uses: actions/upload-artifact@main
with:
name: ${{ matrix.executable }}-linux-${{ matrix.compiler }}-${{ github.sha }}
path: |
${{ matrix.executable }}
chdman
unidasm
if-no-files-found: error
8 changes: 5 additions & 3 deletions .github/workflows/ci-macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ permissions:
contents: read

jobs:

build-macos:
runs-on: macOS-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
- name: Install dependencies
run: brew install python3 sdl2
- name: Build
Expand All @@ -36,10 +37,11 @@ jobs:
run: make -j2
- name: Validate
run: ./mame -validate
- uses: actions/upload-artifact@master
- uses: actions/upload-artifact@main
with:
name: mame-macos-${{ github.sha }}
path: |
mame
chdman
unidasm
if-no-files-found: error
8 changes: 5 additions & 3 deletions .github/workflows/ci-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ permissions:
contents: read

jobs:

build-windows:
runs-on: windows-latest
defaults:
Expand All @@ -46,7 +45,9 @@ jobs:
- uses: msys2/setup-msys2@v2
with:
install: git make mingw-w64-x86_64-${{ matrix.compiler }} mingw-w64-x86_64-python mingw-w64-x86_64-lld mingw-w64-x86_64-llvm mingw-w64-x86_64-libc++
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
- name: Build
env:
MINGW64: "/mingw64"
Expand All @@ -59,10 +60,11 @@ jobs:
run: make -j3
- name: Validate
run: ./${{ matrix.executable }}.exe -validate
- uses: actions/upload-artifact@master
- uses: actions/upload-artifact@main
with:
name: ${{ matrix.executable }}-windows-${{ matrix.compiler }}-${{ github.sha }}
path: |
${{ matrix.executable }}.exe
chdman.exe
unidasm.exe
if-no-files-found: error
7 changes: 5 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ jobs:
build-docs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update
Expand All @@ -27,9 +29,10 @@ jobs:
run: make -C docs html
- name: Build PDF
run: make -C docs latexpdf
- uses: actions/upload-artifact@master
- uses: actions/upload-artifact@main
with:
name: mame-docs-${{ github.sha }}
path: |
docs/build/html
docs/build/latex/MAME.pdf
if-no-files-found: error
4 changes: 3 additions & 1 deletion .github/workflows/hash.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ jobs:
validate:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
- name: Install dependencies
run: |
sudo apt-get update
Expand Down
7 changes: 5 additions & 2 deletions .github/workflows/language.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,13 @@ jobs:
build-language:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does git describe report when you do this? Does this mean the artifact binaries report “unknown” in place of a git revision now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I just checked, and apparently it can still work out how many revisions to the last tag, etc.

- name: Compile message catalogs
run: for x in language/*/*.po ; do python scripts/build/msgfmt.py --output-file "`dirname "$x"`/`basename "$x" .po`.mo" "$x" ; done
- uses: actions/upload-artifact@master
- uses: actions/upload-artifact@main
with:
name: mame-language-${{ github.sha }}
path: language/*/*.mo
if-no-files-found: error
Loading