Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade checkout and upload-artifacts actions #12880

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

Margen67
Copy link
Contributor

The default branch of checkout and upload-artifact was renamed to main years ago:

upload-artifacts >v1 doesn't error by default if artifacts aren't found: https://github.com/actions/upload-artifact/?tab=readme-ov-file#customization-if-no-files-are-found

checkout >v1 doesn't fetch the entire commit history by default: https://github.com/actions/checkout?tab=readme-ov-file#checkout-v4

@rb6502
Copy link
Contributor

rb6502 commented Oct 14, 2024

I don't quite understand the problem here. MAME's primary branch is still called "master" so no changes should be necessary.

@Margen67
Copy link
Contributor Author

I don't quite understand the problem here. MAME's primary branch is still called "master" so no changes should be necessary.

The master branch of these actions is outdated and no longer used. If you're specifying the master branch I assume you're trying to get the latest version of them.
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsuses

@holub
Copy link
Contributor

holub commented Oct 14, 2024

If you rename workflow to main, that's not magically change our masters and slaves to main.
As long as default branch master - workflow should respect this.

@startaq
Copy link
Member

startaq commented Oct 14, 2024

The PR is fine. This updates the actions we use inside the workflow file. It has nothing to do with the naming of our branches.

@rb6502 rb6502 merged commit 809dbd2 into mamedev:master Oct 14, 2024
9 checks passed
@Margen67 Margen67 deleted the ci branch October 15, 2024 06:46
- uses: actions/checkout@master
- uses: actions/checkout@main
with:
fetch-depth: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does git describe report when you do this? Does this mean the artifact binaries report “unknown” in place of a git revision now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I just checked, and apparently it can still work out how many revisions to the last tag, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants