You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I observed in a recent pull request that src/lib/formats/ap2_dsk.cpp has inconsistent operator spacing/formatting across the file. There are certainly more places in the codebase than just that file, so I'm creating this issue as a holding area for other files (and looping in their owners to determine preferred overall style).
As @galibert and @rb6502 are the copyright holders, it's up to them what the overall style should be for the file.
The text was updated successfully, but these errors were encountered:
My preference on this has evolved over time, but I've ended up at a similar place to some of Vas's recent cleanup change lists: space out expressions, and use parens to make the intent clear even when the compiler will do the right thing anyway due to operator precedence.
Doing a quick skim on the swp30, I think that's pretty close to where OG is at too.
I observed in a recent pull request that
src/lib/formats/ap2_dsk.cpp
has inconsistent operator spacing/formatting across the file. There are certainly more places in the codebase than just that file, so I'm creating this issue as a holding area for other files (and looping in their owners to determine preferred overall style).As @galibert and @rb6502 are the copyright holders, it's up to them what the overall style should be for the file.
The text was updated successfully, but these errors were encountered: