Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding issue for files with inconsistent formatting #13023

Open
MooglyGuy opened this issue Nov 28, 2024 · 2 comments
Open

Holding issue for files with inconsistent formatting #13023

MooglyGuy opened this issue Nov 28, 2024 · 2 comments

Comments

@MooglyGuy
Copy link
Contributor

I observed in a recent pull request that src/lib/formats/ap2_dsk.cpp has inconsistent operator spacing/formatting across the file. There are certainly more places in the codebase than just that file, so I'm creating this issue as a holding area for other files (and looping in their owners to determine preferred overall style).

As @galibert and @rb6502 are the copyright holders, it's up to them what the overall style should be for the file.

@galibert
Copy link
Member

I consider that file to be RB's territory at this point

@rb6502
Copy link
Contributor

rb6502 commented Nov 28, 2024

My preference on this has evolved over time, but I've ended up at a similar place to some of Vas's recent cleanup change lists: space out expressions, and use parens to make the intent clear even when the compiler will do the right thing anyway due to operator precedence.

Doing a quick skim on the swp30, I think that's pretty close to where OG is at too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants