Add CondaURL::pretty_str #2830
Merged
Add CondaURL::pretty_str #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
conda-url-str
branch
from
307ab6c to
5db324c
Compare
AntoinePrv
force-pushed
the
conda-url-str
branch
from
5db324c to
0d4c975
Compare
| @@ -12,6 +12,43 @@ | |||
|
|
|||
| namespace mamba::util | |||
| { | |||
| namespace detail | |||
| { | |||
| // Working around MSVC limitation on private inheritance + using directive | |||
There was a problem hiding this comment.
Can you detail the limitations? I never had any issue with using private inheritance + using directive on Windows, so this must be specific to some uses.
There was a problem hiding this comment.
It works for methods but not dependent types.
class URL {
public:
enum class StripScheme : bool { no, yes };
};
class CondaURL : private URL {
public:
using URL::StripScheme;
};
void f() {
CondaURL::StripScheme strip = {}; // Compile error: private field of URL
}There was a problem hiding this comment.
Or maybe I missed somthing...
| // clang-format off | ||
| enum class StripScheme : bool { no, yes }; | ||
| enum class HidePassword : bool { no, yes }; | ||
| struct Encode |
There was a problem hiding this comment.
Are the limitations mentionned above due to inner types?
JohanMabille
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot it in the previous PR