Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Log the thrown error while validating extracted package cache #1608

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

johnhany97
Copy link
Contributor

Before this PR

When an error is thrown when validating the extracted package cache, the following is seen:

debug    libmamba Verify cache '/home/circleci/micromamba/pkgs' for package extracted directory '_libgcc_mutex-0.1-main'
warning  libmamba Extracted package cache '/home/circleci/micromamba/pkgs/_libgcc_mutex-0.1-main' is invalid'
debug    libmamba '_libgcc_mutex-0.1-main' extracted directory cache is invalid
error    libmamba Cannot find a valid extracted directory cache for '_libgcc_mutex-0.1-main.tar.bz2'

After this PR

The actual error encountered is no longer swallowed and is instead logged to help the user debug the issue further.

@wolfv wolfv merged commit d8cd9c5 into mamba-org:master Apr 1, 2022
@wolfv
Copy link
Member

wolfv commented Apr 1, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants