Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passthrough QEMU_LD_PREFIX to subprocesses with empty environments #1533

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

chrisburr
Copy link
Contributor

When running with emulation I've hit a couple of cases where mamba's subprocesses fail due to QEMU_LD_PREFIX not being set causing. I don't particularly like this solution but I don't see a cleaner option other than maybe centralising the creation of subprocesses and having a way of configuring the environment of subprocesses (e.g. MAMBA_ENV_xxxx environment variables).

What do you think?

@chrisburr chrisburr force-pushed the passthrough-qemu-prefix branch from 3fb5f2b to 9b7444d Compare February 24, 2022 07:21
@wolfv
Copy link
Member

wolfv commented Feb 24, 2022

I think we should have a list of environment variables that we consider necessary even in a clean environment and propagate all of them. Unfortunately I haven't found such list for Unix / Linux (only for Windows: https://github.com/microsoft/vcpkg-tool/blob/aee79d78ec25ad162197a1f7c6f5a394a9741837/src/vcpkg/base/system.process.cpp#L285 )

@chrisburr
Copy link
Contributor Author

Yeah, the more I think about it the more I agree.

I have a list that I use for some of my pacakges at work (see below) though I think the list might still need to be configurable as a couple of these are quite domain specific.

    r"DISPLAY",
    r"EDITOR",
    r"HOME",
    r"HOSTNAME",
    r"KRB5.*",
    r"LANG",
    r"LC_.*",
    r"OMP_.*",
    r"QEMU.*",
    r"TERM",
    r"TMPDIR",
    r"TZ",
    r"USER",
    r"VISUAL",
    r"VOMS_.*",
    r"X509_.*",
    r"XRD_.*",

@wolfv wolfv merged commit 7dac4d3 into mamba-org:master Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants