Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate libcurl #2356

Open
JohanMabille opened this issue Mar 7, 2023 · 0 comments
Open

Isolate libcurl #2356

JohanMabille opened this issue Mar 7, 2023 · 0 comments
Assignees
@Hind-M
Labels
backward incompatible type::general-improvement type::refactoring

Comments

@JohanMabille
Copy link
Member

libcurl should be isolated in a wrapper and not exposed to the rest of mamba. We should reuse code from powerloader for that (such as https://github.com/mamba-org/powerloader/blob/main/include/powerloader/curl.hpp and https://github.com/mamba-org/powerloader/blob/main/include/powerloader/url.hpp.

The wrapper itself should be an implementation detail of libmamba and not exposed in public APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hind-M Hind-M

Labels
backward incompatible type::general-improvement type::refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JohanMabille @Hind-M