Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[micromamba] 0.21.0 breaks PIP_ config env variables #1468

Closed
austin1howard opened this issue Feb 10, 2022 · 6 comments · Fixed by #1477
Closed

[micromamba] 0.21.0 breaks PIP_ config env variables #1468

austin1howard opened this issue Feb 10, 2022 · 6 comments · Fixed by #1477

Comments

@austin1howard
Copy link
Contributor

austin1howard commented Feb 10, 2022

In Mamba micromamba 0.21.0, environment variables starting with PIP_ (used to configure pip for things like extra indexes, etc.) are being stripped. I think this is part of #1422, in particular this change: wolfv@61c5de7#diff-ebac1cb6982f8e508ff9d8203d56f74aa3da80115d7ca84cc525a131ef23535aR61

There may be good reason to suppress some environment variables, but this line's change only applies to running pip (or in the future some other third party package manager) so I don't think it makes sense to empty the environment variables. At least, env vars which start with PIP_ should be passed through.

@austin1howard austin1howard changed the title Mamba 0.21.0 has broken PIP_ config env variables Mamba 0.21.0 breaks PIP_ config env variables Feb 10, 2022
@austin1howard
Copy link
Contributor Author

I suppose this is more directly related to #1413.

@wolfv
Copy link
Member

wolfv commented Feb 10, 2022

Hi @austin1howard thanks for letting us know. I think it totally makes sense to run the pip command with a pass-through environment so that all env variables are inherited.

@wolfv wolfv changed the title Mamba 0.21.0 breaks PIP_ config env variables [micromamba] 0.21.0 breaks PIP_ config env variables Feb 10, 2022
@wolfv
Copy link
Member

wolfv commented Feb 10, 2022

I've tagged this with micromamba because I don't think this concerns mamba. Correct?

@austin1howard
Copy link
Contributor Author

austin1howard commented Feb 10, 2022

yeah seems so, I'm able to install through "regular" mamba v0.21.

@austin1howard
Copy link
Contributor Author

I know it's trivial but I pushed a PR to remove that line.

@wolfv
Copy link
Member

wolfv commented Feb 10, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants