Use string view instead of const ref to string

mamba-org · Jun 15, 2023 · 9d8ddbd · 9d8ddbd
1 parent 57166de
commit 9d8ddbd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/libmamba/include/mamba/core/util_string.hpp b/libmamba/include/mamba/core/util_string.hpp
@@ -36,7 +36,7 @@ namespace mamba
      * str1 is considered smaller than (or equal to) str2.
      * cf. Channels use case.
      */
-    std::string get_common_substr(const std::string& str1, const std::string& str2);
+    std::string get_common_substr(std::string_view str1, std::string_view str2);
 
     /**
      * Safe non utf-8 wrapping of <cctype> (see its doc).

diff --git a/libmamba/src/core/util_string.cpp b/libmamba/src/core/util_string.cpp
@@ -18,9 +18,9 @@ namespace mamba
     /********************************************************
      *  Implementation of Channels use case util function   *
      *******************************************************/
-    std::string get_common_substr(const std::string& str1, const std::string& str2)
+    std::string get_common_substr(std::string_view str1, std::string_view str2)
     {
-        auto common_str = str1;
+        std::string common_str(str1);
         while ((str2.find(common_str) == std::string::npos))
         {
             if (common_str.find('/') != std::string::npos)