Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various speed ups, neatification, included Quick for test driven development, date component operators as opposed to time intervals and more #63

Merged
merged 11 commits into from
Oct 28, 2015
Merged

Various speed ups, neatification, included Quick for test driven development, date component operators as opposed to time intervals and more #63

merged 11 commits into from
Oct 28, 2015

Commits on Oct 19, 2015

  1. Added convenience init to use instead of date class func. 

    Removed one date class function of the two as it was trivial.
    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    0b367c8 View commit details
    Browse the repository at this point in the history

  2. Retrieving individual components are an expensive operation and we al… 

    …ready have them!

Replaced with an ordinary nil check and assignment
Removed week references as they are not present in this set function and it confuses dateFromComponents
Put timeZone in calendar before converting to NSDate
    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    8c800e6 View commit details
    Browse the repository at this point in the history

  3. class fun date is in fact a convenience init so I created one

    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    e63becc View commit details
    Browse the repository at this point in the history

  4. Included Quick and Nimble test framework to easily test specifications

    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    a275604 View commit details
    Browse the repository at this point in the history

  5. Removed some functions as they are implied by the Comparable protocol

    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    8081206 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feature/QuickNimble' into develop

    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    7bbaf30 View commit details
    Browse the repository at this point in the history

  7. Date component calculations for easier compilation and interpretation… 

    … of expressions.
    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    715215d View commit details
    Browse the repository at this point in the history

  8. Let NSCalendar take care of the leap year calculations. 

    Oh wait! With a small workaround
    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    4d4caf8 View commit details
    Browse the repository at this point in the history

  9. Day expressions are readily included in NSCalendar so I used these. 

    Als included isSameDayAsDate.
Actually you want to remove the ignoreTime as I would use == for a full comparison
    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    c0da410 View commit details
    Browse the repository at this point in the history

  10. Removed superfluous time interval int extension (whoops)

    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    34201c8 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'FixDCCalc' into develop 

    * FixDCCalc:
  Removed superfluous time interval int extension (whoops)
    @Hout
    Hout committed Oct 19, 2015
    Configuration menu
    Copy the full SHA
    0656212 View commit details
    Browse the repository at this point in the history