Various speed ups, neatification, included Quick for test driven development, date component operators as opposed to time intervals and more #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed one date class function of the two as it was trivial.
…ready have them! Replaced with an ordinary nil check and assignment Removed week references as they are not present in this set function and it confuses dateFromComponents Put timeZone in calendar before converting to NSDate
Oh wait! With a small workaround
Als included isSameDayAsDate. Actually you want to remove the ignoreTime as I would use == for a full comparison
* FixDCCalc: Removed superfluous time interval int extension (whoops)
malcommac
added a commit
that referenced
this pull request
Oct 28, 2015
Various speed ups, neatification, included Quick for test driven development, date component operators as opposed to time intervals and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I separated each change in a separate commit. This might be a bit easier than the all-in-one pull request with conflicting merge.
Bear in mind that I added Quick and Nimble. I do not know how to declare the dependency in Cocoapods but I guess that you are more than capable to do this ;-)
Everything tests fine in the unit tests.