Fix ISO8601Formatter parsing dates that end in Z #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why:
> Times are expressed in UTC (Coordinated Universal Time), with a special UTC designator ("Z").
> http://www.w3.org/TR/NOTE-datetime
* `ISO8601Formatter` would fail to parse dates(unless it hit the default case) ending in Z
This change addresses the need by:
* Adding Enum cases to support character counts for dates with Z
* Remove default case of the switch by making it exhaustive
* Add tests for these cases
malcommac
added a commit
that referenced
this pull request
Oct 4, 2015
Fix ISO8601Formatter parsing dates that end in Z
|
Thank you ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
ISO8601Formatterwould fail to parse dates(unless it hit the default case) ending in ZThis change addresses the need by: