-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors in GWSS plots #583
Comments
Looking at this, I have several ideas for small enhancements:
|
Hi @jonbrenas, thanks for raising this. Some comments inline...
This seems like a good idea. However, the parameters would need to account for point 2 below somehow, i.e., how does the user control what happens when multiple contigs are being shown.
I would suggest to focus this issue on being able to plot different colours for different contigs, and to have this be the default behaviour.
I'd suggest raising as a separate issue - it is a common requirement to want to make a figure with multiple GWSS tracks above each other.
Eric Lucas has in the past used the difference of H12 between two cohorts. Suggest to raise as a separate issue. |
Thanks @alimanfoo . I will create the extra issues. As for this one:
We might want to discuss what the new parameters should be. I have the code with a dict of {'contig': 'color'} which is fairly straightforward which lead to my wondering if {'region': 'color'} would not make as much if not more sense. I have already pushed the code that does 1. in the current formalism (i.e., the user can select a line colour, size, ... for the whole plot) and it would probably make more sense to have the dict be {'region': {'option': 'value'}} to extend the functionality (but that becomes a behemoth of a data structure). The other issue is that 'different contigs' is currently limited. There is no option for '23' and computing H12 on '23X' crashes Colab (by using all the RAM) even with a reasonable sample set (such as 'AG1000G-AO') and big windows (e.g., 10 000 bp). |
Hi @jonbrenas, cc @leehart, I think what we're looking for here is just ability to have colors alternate between contigs whenever data from multiple contigs is plotted. I.e., conventional manhattan-style plots. I.e., something like this... What about just having a |
@alimanfoo mentioned that we now offer the possibility to plot the various WGSS analyses for whole chromosomes (and even for the whole genome) but that, because they are all drawn the same way, it is hard to see where chromosome arms change. The idea would be to have a different colour for each one.
The text was updated successfully, but these errors were encountered: