Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting the week on Monday #15

Open
matthieucalu opened this issue Aug 22, 2014 · 14 comments
Open

Starting the week on Monday #15

matthieucalu opened this issue Aug 22, 2014 · 14 comments

Comments

@matthieucalu
Copy link

In Europe calendars start the week on Monday instead of Sunday.
Is it possible to choose this?
If not, which part of the code should I look at to change this?

@rginnow
Copy link

rginnow commented Sep 4, 2014

I believe this is a PHP option itself. If you set it in your php.ini (or somewhere like that) if you echo day[0] it may come out as monday. Search around google and i'm sure you'll find an option for that somewhere.

@makzumi
Copy link
Owner

makzumi commented Sep 4, 2014

Hi, I have not set a method for a start day, I didnt event think of it, I'll add that as soon as i can. :)

@makzumi
Copy link
Owner

makzumi commented Sep 4, 2014

And sorry, i didnt even notice this issue was open, i didnt get notified

@ronnievisser
Copy link

When will this be fixed?

@urbankid
Copy link

urbankid commented Oct 2, 2014

I'm also interested in finding a solution to start the week on Monday!

@kremsy
Copy link

kremsy commented Nov 15, 2014

Im using your great plugin since today and for my project I would really need that the week starts on monday!

@davidgras
Copy link

Hi! github-newbie here, with newbie doubts.
I need that feature working whithin a pair of weeks maximum, so I was thinking to develop by myself but I've found out that it's already done on several related forked projects.
What should I do? Why that projects haven't done a pull request of this feature? How things are done around here? Thanks ^^

@makzumi
Copy link
Owner

makzumi commented Dec 18, 2014

Hi Folks!
I'm real sorry I havent been able to update this thing, I've been buried in other projects for weeks now :S
I can't really update this right now, maybe after x-mas, sooo sorry :(

@davidgras
Copy link

Don't worry makzumi, take it easy ;)

I just want to understand what's the best behaviour for the community, for the owner:

  • forked the project, do some development and pull requests
  • forked a forked project, do some development and pull requests (Can I do a pull requests to the original project from a forked-forked project?? I don't think so :S)
  • asks the forked project author to do pull requests

@rginnow
Copy link

rginnow commented Dec 18, 2014

David,

If you have seen it done in other projects and can find out where its done
in their code, fork Makzumi's project and fix it for him. Then do a pull
request with his and your code and github will show the differences and all
you do is describe the change you made. Makzumi can then accept or deny
your pull request. Be aware that I will check to make sure your fix does
actually work. If makzumi hasn't had the time, I'm going to help and try to
fix this myself as well.

Makzumi, if you would like help, I will gladly dedicate some time to these
issues.

@davidgras
Copy link

Understood, it seems very neat!
Thank you and sorry for the off-topic.

@rginnow
Copy link

rginnow commented Dec 19, 2014

@davidgras No problem, if you are new to Git, I recommend finding tutorials either by Github, Bitbucket or elsewhere around the internet.

As for this project, I'm looking into a fix for this now.

@kazrusm
Copy link

kazrusm commented Jan 10, 2015

I decided this issue.
We must go to vendor/..../Calendar.php
In the function buildBody(), after this row:

$startingDay = date('N', strtotime('first day of this month', strtotime($now_date)));

we must add:

$startingDay = $startingDay - 1;

Before generate calendar, we must rename array elements in setDayLabels

@Donny5300
Copy link

@kazrusm this is only for month view, not for the week view?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants