Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Annotation Processor support #290

Closed
making opened this issue Nov 17, 2022 · 5 comments
Closed

Delete Annotation Processor support #290

making opened this issue Nov 17, 2022 · 5 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@making
Copy link
Owner

making commented Nov 17, 2022

after #289

@making making added the enhancement New feature or request label Nov 17, 2022
@making making added this to the 0.13.0 milestone Nov 17, 2022
@odrotbohm
Copy link

Can you elaborate why you'd want to remove the annotation processor? I am wondering, as the AP-generated code was used as counterargument to my suggestion in #269. So, why would you drop that support?

I just came back here to see what the current state of affairs was, was thinking about suggesting providing a type-level annotation (like @BeanConstraints), that'd essentially work like the @ConstraintTarget target annotation but without actually having to annotate each method but rather discover them in the AP by following the Java Beans spec.

@making
Copy link
Owner Author

making commented Feb 23, 2023

It's based on your comment
#269 (comment)

I saw the annotation processor but would like to be able not having to annotate the DTO types with validation-specific annotations as I use Yavi to avoid annotations in the first place.

I thought this comment made sense.
And I haven't seen anyone using this feature, and I don't think it provides value for maintenance costs (tests can fail depending on the JDK version).

Would it be helpful to continue supporting Annotation Processor?

@odrotbohm
Copy link

That was more an explanation for why I filed the request. If in doubt, I would like to avoid the string references more than I would like to avoid the annotations. Especially if the latter was only one to be put on a form or DTO type. So yes, the AP is just fine, I think. 🙃

@making
Copy link
Owner Author

making commented Feb 24, 2023

Thank you. User feedback is important. So far, only you have provided feedback on the annotation processor.
It was that I didn't want to use annotations :) So I decided to remove this feature.
If you use the annotation processor, I'll remove the deprecation and create an issue on the class level annotation.

@odrotbohm
Copy link

Me trying to avoid the annotations, doesn't mean that the APT is not a useful feature to others. So yeah, please keep it around. I'll create a ticket for the type-level annotation.

@making making added the wontfix This will not be worked on label Feb 28, 2023
@making making removed this from the 0.13.0 milestone Apr 12, 2023
@making making closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants