Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash the member PIN code #602

Open
emanuelen5 opened this issue Dec 29, 2024 · 2 comments
Open

Hash the member PIN code #602

emanuelen5 opened this issue Dec 29, 2024 · 2 comments
Labels
public:member Member part of the public interface

Comments

@emanuelen5
Copy link
Member

emanuelen5 commented Dec 29, 2024

People tend to use a familiar PIN code when they change it manually, so let's hash it so it can't be read back from the backend.

@emanuelen5 emanuelen5 added the public:member Member part of the public interface label Dec 29, 2024
@HalfVoxel
Copy link
Contributor

HalfVoxel commented Dec 30, 2024

Right now we allow people to view their pin code on the member portal. This would no longer be possible, in that case.
Also: the pin code is only 4 digits. Any hash could be almost trivially brute-forced.

In any case, I think we should deprecate the pin code now that passwords are properly supported for regular members. I don't see why we should have two password-like systems.
Memberbooth already supports logging in using either the pin code or the password.

@emanuelen5
Copy link
Member Author

Right now we allow people to view their pin code on the member portal. This would no longer be possible, in that case.

Yes.

I don't see why we should have two password-like systems.

The PIN code serves a different purpose than the password.

  • The PIN code doesn't protect any sensitive information (only for printing labels and show access).
  • The password is used for logging in to the admin page, where there is sensitive information.

I want the PIN to be easy to type so that I can easily log in to the Memberbooth. But I certainly wouldn't want my password to be that easy. And I (including probably many more) use a password manager that generates the passwords for me, so they are also hard to type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
public:member Member part of the public interface
Projects
None yet
Development

No branches or pull requests

2 participants