You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 28, 2022. It is now read-only.
Hello there! I am trying to use maker.service('transactionManager')according to the docs, by passing a transaction promise, but for some reason, it doesn't track anything at all or throw any error.
Sample code, that doesn't log anything in the console and never resolve the promise:
So in your case it would be the clipper.redo() function. You might need to move the reference to the contract inside a redo method on the LiquidationService. So a little bit of pseudo code using your example:
...
// move this call into a "redo" method on the LiquidationService:// const clipperContract = maker.service('liquidation')._clipperContractByIlk(collateralType);// const transaction = clipperContract.redo(auctionId, walletAddress);consttransaction=maker.service('liquidation').redo(auctionId,walletAddress);consttransactionManager=maker.service('transactionManager');awaitnewPromise((resolve,reject): void=>{transactionManager.listen(transaction,{
...
Wouldn't it be desirable if transactionManager will throw an error if decorator is not present?
Why do we actually need a decorator? Isn't transactionManager or at least its confirm method implements a generic polling functionality that only needs transaction hash to be able to check if it was mined or not?
Anyway, I made a PR #298 based on your suggestion, please have a look 🙂
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hello there! I am trying to use
maker.service('transactionManager')
according to the docs, by passing a transaction promise, but for some reason, it doesn't track anything at all or throw any error.Sample code, that doesn't log anything in the console and never resolve the promise:
Does
transactionManager
only track certain types of transactions? Or do I miss something?The text was updated successfully, but these errors were encountered: