Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ace with CodeMirror #23

Closed
lynnaloo opened this issue Mar 9, 2015 · 6 comments
Closed

Replace Ace with CodeMirror #23

lynnaloo opened this issue Mar 9, 2015 · 6 comments
Assignees
Labels

Comments

@lynnaloo
Copy link
Collaborator

lynnaloo commented Mar 9, 2015

Removing the Ace library from static and adding the CodeMirror npm module to robotnik.js

@lynnaloo lynnaloo self-assigned this Mar 9, 2015
@lynnaloo
Copy link
Collaborator Author

lynnaloo commented Mar 9, 2015

I'm going to merge with #22 before I do a PR for this

@Resseguie
Copy link
Collaborator

Just for completeness sake, can we document here the reasoning for switching editors? (I don't have much experience with either, so this is partly because I'm curious to learn the pros/cons.)

@lynnaloo
Copy link
Collaborator Author

lynnaloo commented Mar 9, 2015

@makenai Did you have any specific preference for one over the other? There is an npm package for CodeMirror which is nice. Googling is showing points in favor of both so I don't know that there's a clear winner.

This is an interesting thread: adobe/brackets#1142

@BrianGenisio
Copy link
Collaborator

I have a lot of experience with CodeMirror... I use it in my dayjob project. It is solid. I don't know anything about Ace, but from my understanding, it is equally solid.

@Resseguie
Copy link
Collaborator

CodeMirror was used by j5-chrome for the original Chromebots too.

@monteslu
Copy link

monteslu commented Mar 9, 2015

Don't remember why we switched on chromebots, but I'm really liking codemirror

@makenai makenai added the wontfix label May 3, 2015
@makenai makenai closed this as completed May 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants