Spreewald should never check the current driver name, but its class

[codener]

In multiple places in web_steps.rb, spreewald distinguishes Capybara drivers by their name. However, since the driver name is variable (i.e. it is chosen by project developers), this is a weak means for differentiation.

Spreewald should check the driver's class instead, e.g. check if it is Capybara::Selenium::Driver or the like.

[triskweline]

Note that there are many JavaScript capable drivers that are not using Selenium. E.g. capybara-webkit, poltergeist, headless chrome in the near future.

[foobear]

@codener I'm not sure I understand how checking against Capybara::Selenium::Driver is better than checking against :selenium. Class names are more subject to change than an identifier like :selenium, IMHO.

[triskweline]

Neither solution has ever broke down in us in 10 years or so? Maybe just decide on one and expose with via Spreewald.javascript_scenario? so people can override it if needed.

[foobear]

Today I worked with multiple Chrome sessions because of device emulation. Capybara.current_driver == :selenium will only work for exactly one driver that is named like that.

I vote for using Capybara.current_session.driver.is_a?(Capybara::Selenium::Driver) instead.
We should still place it inside a method that can be overwritten if needed.

[triskweline]

Is this always right?

Before '@javascript' do
  @javascript_scenario = true
end

[foobear]

Not really. For example, we used @mobile in a project recently which implied using Selenium because of mobile emulation, not because it supports JavaScript.

Would still favor checking inheritance.

[codener]

Today, I could not use the I switch to the new tab step, because it requires the current driver to be called :selenium. However, my project features multiple Javascript-capable drivers, and the driver for that very test was not named :selenium.

Would be awesome if we could fix Spreewald any time soon.

[triskweline]

Maybe just decide on one and expose with via Spreewald.javascript_scenario? so people can override it if needed.

This is the one solution we all agreed on.

[judithroth]

Done with 1.12.2 / 196b016