Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to build all and release #89

Open
mak448a opened this issue Nov 18, 2024 · 4 comments
Open

Workflow to build all and release #89

mak448a opened this issue Nov 18, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mak448a
Copy link
Owner

mak448a commented Nov 18, 2024

Take inspiration from https://github.com/mq1/TinyWiiBackupManager/blob/0.3.8/.github/workflows/release.yml

@mak448a mak448a added this to Planning Nov 19, 2024
@mak448a mak448a added the enhancement New feature or request label Nov 19, 2024
@mak448a mak448a pinned this issue Nov 19, 2024
@mak448a mak448a unpinned this issue Nov 19, 2024
@mak448a mak448a added the good first issue Good for newcomers label Dec 8, 2024
@ngaihan
Copy link

ngaihan commented Dec 9, 2024

Hi! I was wondering if I could take a look into this and see what I could do. Here to try to learn how to do github workflows. Also I was wondering, from the workflow you attached, they run it on macOS. I assume this workflow should use ubuntu?

Edit: Just noticed that you already had workflows implemented. Does that mean the main focus should be on getting them released?

@mak448a
Copy link
Owner Author

mak448a commented Dec 10, 2024

Yup. This issue is asking to create a release GitHub action. Ideally, it should build the Windows and macOS versions and make a GitHub release (on run).

The Linux version is a Flatpak, so you should edit src/flatpak_builder/io.github.mak448a.QTCord.metainfo.xml to include the latest release.
But you don't have to, since I usually manually update that before relasing.

@ngaihan
Copy link

ngaihan commented Dec 10, 2024

Thank you for getting back to me! I'll look into it then. I don't think I have permissions to commit and push to the repo?

@mak448a
Copy link
Owner Author

mak448a commented Dec 10, 2024

If you make a fork, you can easily make GitHub actions for testing. I'd recommend that for small changes like this.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: No status
Development

No branches or pull requests

2 participants