-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace conflicts #48
Comments
Thanks for contacting me. Yes I want to ship very feature reach high quality Blazor components. More to be come... It is an interesting issue. I have not encountered it so far. Could you give me some code example? Also not sure how are you adding Meanwhile you can try out these, might work:
About the naming convention you are right. I have started to work on a this project with the current name. By the time I wanted to upload packages to Nuget.org realized "Blazor" name is taken. So I needed to "prefix" packages. I was thinking to rename all the projects and fix namespaces, etc. but seemed to much time which I wanted to spend on Features and Quality. |
Thanks for responding :) I created the following project with a name where the issue occurs. Each of the three pages has examples of things I have tried. You will notice they all produce build errors. https://github.com/fargs/NamespaceConflictExample.Blazor Hope that helps. When I get the project wrapped I'll let you know if that works. Thanks! |
Hi @fargs Checked your example code. Yes it has build error. It is an unfortunate Blazor bug. I have reported quite a few bugs to Microsoft. Hope they fix it soon. At some point I might also find some time to align Namespaces with Package names. Meanwhile you can do what I suggested. Create a Razor Class Library for 3rd party components (or just your components). Do not put "Blazor" into this project name. Wrap around my components or just use them in as Blazor suggests it. Create all your pages as components and reference this new 3rd party Library to your app. It works. Updated code: NamespaceConflictExample.Blazor.zip |
Hi @fargs, I will try to publish new version 1.2 with other new components by end of this year. |
Hey @majorimi, That's awesome, thanks! I ended up forking your repo and included it in my project as a git submodule. I did the same rename refactor to Majorsoft.Blazor for the debounce component which was the main one I was after. I was going to offer to do that work for you but the holidays took over. Very happy to remove my fork and git submodule and use your package directly now! Happy new year! |
Hi @fargs, Yes unfortunately holidays were delaying me as well. So rename is still not published. I'm still trying to finishing up a new component. Will be done soon and released. Thanks. Happy new year for you as well! |
Ok v1.2.0 was released today with your request in it... |
I just removed my submodules and included the latest version as a nuget package reference and works like a charm. Thanks!! |
Hi @fargs, Thanks. |
I have a namespace conflict issue when using your library. My namespace for my project has a ".Blazor." in it and yours starts with Blazor.Components.
When this issue is closed it shouldn't be an issue dotnet/razor#7670
I was expecting your library to be Majorsoft.Blazor.Components which would also resolve the issue.
Any suggestions for a workaround?
Thanks, your library is providing some very key components that are missing from even some of the larger commercial component libraries!
The text was updated successfully, but these errors were encountered: