Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor scrolls all the way up/down when pressing PgUp/PgDn #575

Closed
Misterke opened this issue Jan 25, 2022 · 0 comments · Fixed by #795
Closed

Editor scrolls all the way up/down when pressing PgUp/PgDn #575

Misterke opened this issue Jan 25, 2022 · 0 comments · Fixed by #795
Assignees
Milestone

Comments

@Misterke
Copy link

Describe the bug:
When using the editor of Mainsail on a longer file (ex. a gcode file), pressing PgDn or PgUp (PageDown or PageUp) does not scroll down/up a single page, but jumps all the way to the end/beginning of the file.

Expected behavior:
Expectation is that both keys would only scroll the content a single page, i.e. roughly 90-100% of the number of lines actually visible on the screen.

I have tested this in both Chrome and Edge and as far as I can tell this problem is 100%. Trying to debug the Javascript, I get the impression the amount being scrolled is calculated from the height of some element which actually has its height determined by the complete content of the editor, not just the lines visible on the screen. As I'm not sufficiently versed in this type of code, I could not pinpoint the cause further, sorry ...

@dw-0 dw-0 linked a pull request May 15, 2022 that will close this issue
@dw-0 dw-0 assigned meteyou and unassigned freasy May 15, 2022
@dw-0 dw-0 modified the milestones: v2.3.0, vNext Jun 13, 2022
@dw-0 dw-0 modified the milestones: vNext, v2.3.0 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants