Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit is wrong on Pressure Advance #1052

Closed
richfelker opened this issue Aug 30, 2022 · 0 comments · Fixed by #1053
Closed

Unit is wrong on Pressure Advance #1052

richfelker opened this issue Aug 30, 2022 · 0 comments · Fixed by #1053
Labels
⚡ Type: Bug Something isn't working
Milestone
v2.3.0

Comments

@richfelker
Copy link

richfelker commented Aug 30, 2022 •
edited
Loading

Mainsail Version:

all

What happened?

The pressure advance panel shows pressure advance units as mm/s.

What did you expect to happen instead?

I expected it to show the actual units for pressure advance, which are seconds (mm/(mm/s) = s).

How to reproduce this bug?

Look at the pressure advance panel
@richfelker richfelker added the ⚡ Type: Bug Something isn't working label Aug 30, 2022
@dw-0 dw-0 added this to the v2.3.0 milestone Aug 31, 2022
@dw-0 dw-0 mentioned this issue Aug 31, 2022
Merged
@dw-0 dw-0 closed this as completed in #1053 Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging a pull request may close this issue.

fix: use correct unit for pressure advance dw-0/mainsail
2 participants
@richfelker @dw-0