From ea47009b1161bee8c9a43f7eff6e137bdde7c6db Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Wed, 25 Jan 2017 17:37:14 +0100 Subject: [PATCH 1/2] dummy/components: Explicitly set attributeBindings to [] to test freezing --- tests/dummy/app/components/data-test-component.js | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 tests/dummy/app/components/data-test-component.js diff --git a/tests/dummy/app/components/data-test-component.js b/tests/dummy/app/components/data-test-component.js new file mode 100644 index 00000000..18d30385 --- /dev/null +++ b/tests/dummy/app/components/data-test-component.js @@ -0,0 +1,5 @@ +import Ember from 'ember'; + +export default Ember.Component.extend({ + attributeBindings: [], +}); From cf32689826adbf0a1075c9c2c824ab0d2109ccf0 Mon Sep 17 00:00:00 2001 From: Tobias Bieniek Date: Wed, 25 Jan 2017 17:41:52 +0100 Subject: [PATCH 2/2] dummy/components: Add comment explaining the reasons for this override --- tests/dummy/app/components/data-test-component.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/dummy/app/components/data-test-component.js b/tests/dummy/app/components/data-test-component.js index 18d30385..33257dcc 100644 --- a/tests/dummy/app/components/data-test-component.js +++ b/tests/dummy/app/components/data-test-component.js @@ -1,5 +1,7 @@ import Ember from 'ember'; export default Ember.Component.extend({ + // we're explicitly setting attributeBindings here to test that + // we are correctly slice()ing the frozen array if it exists already attributeBindings: [], });